Skip to content

fix: async indicator in canon yield#528

Closed
vados-cosmonic wants to merge 1 commit into
WebAssembly:mainfrom
vados-cosmonic:fix=async-indicator-in-canon-yield
Closed

fix: async indicator in canon yield#528
vados-cosmonic wants to merge 1 commit into
WebAssembly:mainfrom
vados-cosmonic:fix=async-indicator-in-canon-yield

Conversation

@vados-cosmonic
Copy link
Copy Markdown
Collaborator

This commit fixes the variable name in the python code that seems to be referencing whether it's an async yield rather than a sync yield, but is written as 'sync'.

This commit fixes the variable name in the python code that seems to
be referencing whether it's an *async* yield rather than a *sync*
yield, but is written as 'sync'.

Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
@lukewagner
Copy link
Copy Markdown
Member

As a convention throughout the CABI (commented in CanonicalOptions), to avoid writing async_ everywhere, we use sync, so I'd prefer to do that consistently.

@vados-cosmonic
Copy link
Copy Markdown
Collaborator Author

Ah thanks for clarifying this -- will close his then!

@vados-cosmonic vados-cosmonic deleted the fix=async-indicator-in-canon-yield branch June 27, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants